Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xtask/pipeline: Fix publish task #2711

Merged
merged 6 commits into from
Aug 28, 2023
Merged

xtask/pipeline: Fix publish task #2711

merged 6 commits into from
Aug 28, 2023

Commits on Aug 28, 2023

  1. xtask/pipeline: Fix publish task 

    which was previously stuck in an infinite loop after successfully
publishing a crate. The error originated in the code only checking for
error conditions but not breaking out of the inner infinite loop in case
of success.
    @har7an
    har7an committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c0f3c79 View commit details
    Browse the repository at this point in the history

  2. xtask: Improve publish failure UX 

    by offering the user more actions to choose from when an error occured.
    @har7an
    har7an committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b889fad View commit details
    Browse the repository at this point in the history

  3. utils/assets: Add generated prost files to assets 

    to make sure they're available at build time and are picked up by all
components. It seems we hit some strange bug with the build script
where, when running `cargo publish --dry-run` the build script **is
not** run before regularly compiling zellij-utils. This shouldn't happen
according to the docs, but I cannot explain what's causing it. So we're
using this as a workaround for now to make a smooth release.
    @har7an
    har7an committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b4ee2ef View commit details
    Browse the repository at this point in the history

  4. xtask: Prevent accidental git commit deletion 

    when dry-running a publish.
    @har7an
    har7an committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1c1c860 View commit details
    Browse the repository at this point in the history

  5. utils: Add comments to protobuf-related code 

    to explain why these changes were performed. The comments all include a
link to an issue comment explaining the situation in greater detail.
    @har7an
    har7an committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    dce3689 View commit details
    Browse the repository at this point in the history

  6. xtask: Build protobuf definitions 

    when building any part of the project, similar to how we build the
plugins when required. This should ensure that all crates built through
`cargo xtask` (which is the officially supported build method) will
receive up-to-date protobuf definitions.
    @har7an
    har7an committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3bb7c57 View commit details
    Browse the repository at this point in the history