Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(layout): Support environment variables in cwd (#2288) #2291

Merged
merged 6 commits into from
Apr 28, 2023
Merged

feat(layout): Support environment variables in cwd (#2288) #2291

merged 6 commits into from
Apr 28, 2023

Commits on Mar 15, 2023

  1. feat(layout): Support environment variables in cwd (zellij-org#2288) 

    * add `shellexpand` as dependency
* expand environment variable in kdl parser's `parse_cwd()`
    @shahamran
    shahamran committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    2a8ca06 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Fix and enhance environment variable expansion. 

    * Return a proper `ConfigError` on failures.
* Replace raw cwd parsing with `parse_cwd()`.
* Add tests that verify correct expansions.
    @shahamran
    shahamran committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    1a15c27 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Perform env var expansion in more contexts.

    @shahamran
    shahamran committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    ae476bc View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. feat(layout): Rewrite env var tests as snapshots.

    @shahamran
    shahamran committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f977bda View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2023

  1. Merge remote-tracking branch 'upstream/main' into fix-2288-env-var-in… 

    …-cwd
    @shahamran
    shahamran committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    ec70ef9 View commit details
    Browse the repository at this point in the history

  2. Update layout env var expansion test snapshot.

    @shahamran
    shahamran committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    cf2fdb8 View commit details
    Browse the repository at this point in the history