Add action `QueryTabNames` to list all tab names #2145

naosense · 2023-02-08T07:09:07Z

To resolve #2098 , as shown below

zellij-server/src/lib.rs

zellij-client/src/lib.rs

zellij-client/src/cli_client.rs

imsnif · 2023-02-20T08:03:48Z

Hey @naosense - what's the status of this PR?

naosense · 2023-02-20T08:08:57Z

I think it's ready for review

imsnif

Great work @naosense - also thanks for taking care of the merge conflict.

I left some comments about naming, and otherwise - can we maybe add a test for this? Preferably one that tests the entire flow with the cli action. I think there are a few examples in tab_integration_tests.

zellij-client/src/lib.rs

zellij-server/src/lib.rs

naosense · 2023-02-21T03:21:58Z

I left some comments about naming, and otherwise - can we maybe add a test for this? Preferably one that tests the entire flow with the cli action. I think there are a few examples in tab_integration_tests.

after i read tab_integration_tests, i didnt find similar test. i want to run a command zellij action query-tab-names, then test the snapshot, but i cant figure out how to run cmd. Am i in the right direction?

imsnif · 2023-02-21T08:15:37Z

Sorry @naosense - I meant this file, my mistake: https://github.com/zellij-org/zellij/blob/main/zellij-server/src/unit/screen_tests.rs#L989

Just be aware that you'll need to adjust your test a little bit, since the normal snapshot probably won't help you here (as it's taking a snapshot of the render and not the new log).

* fix(layout): tab focus * style(fmt): rustfmt

…g#2198) * fix(cli): the new-tab action now also searches for layouts in the layout dir * style(fmt): rustfmt * fix(tests): add missing parameter to cli action

…#2200) * fix(themes): missing tokyo-night-dark theme * fix(kdl): new-tab keybind also looks in layout_dir for layouts

* fix(cli): properly set cwd for edit panes * fix(layouts): properly set cwd for edit panes * style(fmt): rustfmt

* fix(layouts): do not relayout twice on auto_layout * style(fmt): rustfmt

* fix(cli): take default shell from config if it exists when opening new tab * fix(cli): take layout dir from config when opening new tab if it exists * style(fmt): rustfmt

…rs (zellij-org#2204)

* style(fmt): remove warnings * fix(swap-layouts): introduce exact panes constraint * fix(swap-layouts): improve floating pane swap layout ux * style(fmt): rustfmt

…org#2213)

* fix(sixel): report pixel size in winsize change ioctl * style(fmt): rustfmt

…rg#2145) * extend display char in tab * Add action to list all tab names * print tab names and remove logs * change msg name, and handle Log in normal client * fix log * resolve code conflict * change var name * add snapshot test * fix failed test case * restore snapshot * Revert "restore snapshot" This reverts commit b97a951. * restore snapshot * revert snapshot * fix(layout): various parser and ui fixes (zellij-org#2191) * fix(layout): error on nodes outside layout node * fix(layout): move stacked property to pane * fix(layout): various stack exceptions * fix(ui): non-flexible stacked pane titles now take up their full length * fix(ui): stack titles with no-pane-frames take up their proper length * style(fmt): rustfmt * docs(changelog): layout fixes * fix(messaging): cache hold pane messages by their tab_id if the tab is not ready (zellij-org#2196) * fix(messaging): cache hold pane messages by their tab_id if the tab is not ready * style(fmt): rustfmt * docs(changelog): open panes fix * fix(layout): tab focus (zellij-org#2197) * fix(layout): tab focus * style(fmt): rustfmt * docs(changel0g): tab focus fix * fix(cli): new-tab now also looks in layout_dir for layouts (zellij-org#2198) * fix(cli): the new-tab action now also searches for layouts in the layout dir * style(fmt): rustfmt * fix(tests): add missing parameter to cli action * docs(changelog): new-tab cli layout folder fix * fix(kdl): new-tab keybind looks in layout_dir for layouts (zellij-org#2200) * fix(themes): missing tokyo-night-dark theme * fix(kdl): new-tab keybind also looks in layout_dir for layouts * docs(changelog): new-tab keybind layout folder fix * fix(cli): edit cwd (zellij-org#2201) * fix(cli): properly set cwd for edit panes * fix(layouts): properly set cwd for edit panes * style(fmt): rustfmt * docs(changelog0 * fix(layouts): do not relayout twice on auto_layout (zellij-org#2202) * fix(layouts): do not relayout twice on auto_layout * style(fmt): rustfmt * fix(new-tab): get config parameters from config file (zellij-org#2203) * fix(cli): take default shell from config if it exists when opening new tab * fix(cli): take layout dir from config when opening new tab if it exists * style(fmt): rustfmt * docs(changelog): new-tab config parameters * fix(grid): only use background pending styling when deleting characters (zellij-org#2204) * docs(changelog): neovim underline fix * feat(layouts): exact panes constraint (zellij-org#2206) * style(fmt): remove warnings * fix(swap-layouts): introduce exact panes constraint * fix(swap-layouts): improve floating pane swap layout ux * style(fmt): rustfmt * docs(changelog): exact panes constraint * fix(pty): report no-cwd for empty path returned from sysinfo (zellij-org#2213) * fix(sixel): report pixel size in winsize change ioctl (zellij-org#2212) * fix(sixel): report pixel size in winsize change ioctl * style(fmt): rustfmt * docs(changelog): various fixes * style(code): naming * test(log): adjust query tab names test to look at the log message * style(fmt): rustfmt --------- Co-authored-by: Aram Drevekenin <[email protected]> Co-authored-by: Jae-Heon Ji <[email protected]>

naosense added 2 commits January 28, 2023 10:39

extend display char in tab

856f428

Merge branch 'zellij-org:main' into main

bbda375

naosense temporarily deployed to cachix February 8, 2023 07:09 — with GitHub Actions Inactive

naosense commented Feb 8, 2023

View reviewed changes

zellij-server/src/lib.rs Outdated Show resolved Hide resolved

naosense commented Feb 8, 2023

View reviewed changes

zellij-client/src/lib.rs Outdated Show resolved Hide resolved

naosense temporarily deployed to cachix February 8, 2023 09:16 — with GitHub Actions Inactive

naosense marked this pull request as ready for review February 8, 2023 09:16

imsnif reviewed Feb 13, 2023

View reviewed changes

zellij-client/src/cli_client.rs Outdated Show resolved Hide resolved

Merge branch 'zellij-org:main' into main

6c96db8

naosense had a problem deploying to cachix February 14, 2023 08:18 — with GitHub Actions Failure

naosense temporarily deployed to cachix February 14, 2023 08:30 — with GitHub Actions Inactive

Merge branch 'zellij-org:main' into main

6e2332b

naosense force-pushed the list_tab_names_2 branch from 31b0066 to 5a4dc22 Compare February 20, 2023 06:16

naosense temporarily deployed to cachix February 20, 2023 06:17 — with GitHub Actions Inactive

naosense temporarily deployed to cachix February 20, 2023 06:20 — with GitHub Actions Inactive

imsnif requested changes Feb 20, 2023

View reviewed changes

zellij-client/src/lib.rs Outdated Show resolved Hide resolved

zellij-server/src/lib.rs Outdated Show resolved Hide resolved

naosense had a problem deploying to cachix February 21, 2023 10:25 — with GitHub Actions Failure

naosense requested a review from imsnif February 21, 2023 10:28

naosense added 8 commits February 23, 2023 10:18

Merge branch 'zellij-org:main' into main

a0c3ef4

Add action to list all tab names

7e58df5

print tab names and remove logs

0ff8083

change msg name, and handle Log in normal client

f97a729

fix log

e483403

resolve code conflict

5e75425

change var name

27d6997

add snapshot test

d9db4e9

imsnif and others added 23 commits March 1, 2023 15:49

docs(changelog): open panes fix

e7e54bb

fix(layout): tab focus (zellij-org#2197)

26ebc6c

* fix(layout): tab focus * style(fmt): rustfmt

docs(changel0g): tab focus fix

85c67b7

fix(cli): new-tab now also looks in layout_dir for layouts (zellij-or…

9029422

…g#2198) * fix(cli): the new-tab action now also searches for layouts in the layout dir * style(fmt): rustfmt * fix(tests): add missing parameter to cli action

docs(changelog): new-tab cli layout folder fix

9360e19

fix(kdl): new-tab keybind looks in layout_dir for layouts (zellij-org…

d61e5e0

…#2200) * fix(themes): missing tokyo-night-dark theme * fix(kdl): new-tab keybind also looks in layout_dir for layouts

docs(changelog): new-tab keybind layout folder fix

112dd9d

fix(cli): edit cwd (zellij-org#2201)

b9e2954

* fix(cli): properly set cwd for edit panes * fix(layouts): properly set cwd for edit panes * style(fmt): rustfmt

docs(changelog0

47a00c6

fix(layouts): do not relayout twice on auto_layout (zellij-org#2202)

d0e41ce

* fix(layouts): do not relayout twice on auto_layout * style(fmt): rustfmt

fix(new-tab): get config parameters from config file (zellij-org#2203)

ba77d11

* fix(cli): take default shell from config if it exists when opening new tab * fix(cli): take layout dir from config when opening new tab if it exists * style(fmt): rustfmt

docs(changelog): new-tab config parameters

1f73112

fix(grid): only use background pending styling when deleting characte…

372342e

…rs (zellij-org#2204)

docs(changelog): neovim underline fix

045c4f8

feat(layouts): exact panes constraint (zellij-org#2206)

7b6cd0c

* style(fmt): remove warnings * fix(swap-layouts): introduce exact panes constraint * fix(swap-layouts): improve floating pane swap layout ux * style(fmt): rustfmt

docs(changelog): exact panes constraint

2c961f0

fix(pty): report no-cwd for empty path returned from sysinfo (zellij-…

73603c9

…org#2213)

fix(sixel): report pixel size in winsize change ioctl (zellij-org#2212)

1e13076

* fix(sixel): report pixel size in winsize change ioctl * style(fmt): rustfmt

docs(changelog): various fixes

9331fe0

style(code): naming

b4903c3

test(log): adjust query tab names test to look at the log message

79b0550

Merge branch 'main' into naosense-list_tab_names_2

6e47fa4

style(fmt): rustfmt

f0fb292

imsnif temporarily deployed to cachix March 1, 2023 15:46 — with GitHub Actions Inactive

imsnif temporarily deployed to cachix March 1, 2023 15:48 — with GitHub Actions Inactive

imsnif merged commit c2fb275 into zellij-org:main Mar 1, 2023

naosense deleted the list_tab_names_2 branch March 2, 2023 06:48

thled mentioned this pull request Jul 3, 2023

Add action QueryPaneNames to list pane names #2602

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add action `QueryTabNames` to list all tab names #2145

Add action `QueryTabNames` to list all tab names #2145

naosense commented Feb 8, 2023 •

edited

Loading

imsnif commented Feb 20, 2023

naosense commented Feb 20, 2023

imsnif left a comment

naosense commented Feb 21, 2023

imsnif commented Feb 21, 2023

Add action QueryTabNames to list all tab names #2145

Add action QueryTabNames to list all tab names #2145

Conversation

naosense commented Feb 8, 2023 • edited Loading

imsnif commented Feb 20, 2023

naosense commented Feb 20, 2023

imsnif left a comment

Choose a reason for hiding this comment

naosense commented Feb 21, 2023

imsnif commented Feb 21, 2023

Add action `QueryTabNames` to list all tab names #2145

Add action `QueryTabNames` to list all tab names #2145

naosense commented Feb 8, 2023 •

edited

Loading