Fix status bar not displaying w/ size=1 and show shortcuts #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mal mode when size=1
|
Looks great. Thank you for your patience in having this reviewed, and congrats on your first Rust PR! |
joshheyse
pushed a commit
to joshheyse/zellij
that referenced
this pull request
Mar 11, 2023
…org#2091) * Fix status bar not displaying if size=1. Show shortcuts if not in normal mode when size=1 * formatting Co-authored-by: Felix Pankratz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2077
This changes behaviour if
status-baris used withsize=1.The issue of the status bar not showing with
size=1arises from usingprintln!when reaching the last line.In this case,
print!will be used instead.This will also show the "second layer" of hints when not in normal mode, changing the first line.
Be careful reviewing, it's my first Rust PR 🚀