Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log path in contributing doc #1927

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Update log path in contributing doc #1927

merged 1 commit into from
Nov 13, 2022

Conversation

naosense
Copy link
Contributor

As pr #1898 changes log path from the hardcoded /temp to std::env::temp_dir(), update contributing.md to avoid unnecessary misleading.

@naosense naosense temporarily deployed to cachix November 12, 2022 04:03 Inactive
@naosense naosense changed the title Update log path Update log path in contributing doc Nov 12, 2022
@naosense
Copy link
Contributor Author

Updated documentation about the log path by the way. Could you please review it? @jaeheonji

jaeheonji
jaeheonji approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@jaeheonji jaeheonji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thank you 😄

@jaeheonji jaeheonji merged commit 8626e7a into zellij-org:main Nov 13, 2022
@naosense naosense deleted the update_log_path branch November 13, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeheonji jaeheonji jaeheonji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naosense @jaeheonji