Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layouts): global cwd #1798

Merged
merged 4 commits into from
Oct 14, 2022
Merged

feat(layouts): global cwd #1798

merged 4 commits into from
Oct 14, 2022

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Oct 14, 2022

This change does two things:

  1. It allows defining a cwd for non-command "normal" terminal panes too. So that we can define panes that start at a certain folder.
  2. It allows defining a global cwd per layout. This cwd will be given to all panes in the layout. If they have a relative cwd, it will be appended to this cwd, if this have an absolute cwd it will override this cwd.
  3. When opening a new tab from the cli with a layout using the zellij action new-tab --layout /path/to/my/layout.kdl, we can now add a --cwd flag that will be used just like the global cwd in 2, and override it if present. This should allow much more flexibility when creating custom layouts.

Thanks @har7an for suggesting this feature!

EDIT: updated the documentation in #1759 - which is where we currently keep our docs for this until release time.

@imsnif imsnif temporarily deployed to cachix October 14, 2022 11:14 Inactive
@imsnif imsnif temporarily deployed to cachix October 14, 2022 11:50 Inactive
@imsnif imsnif merged commit d074bb1 into main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant