-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ux): rerun command pane #1787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all panes that run a command (eg. from the CLI or from a layout) become "command panes".
A command pane does not immediately exit when its command does, but instead displays its exit status on the pane frame, as well as helpful keyboard tips. When in this state, the user can:
<ENTER>
to re-run the command in the pane<Ctrl-c>
to close the paneThis can be very powerful for commands that we run many times. Think of anything you do
up-arrow
+ENTER
for.It can also be really nice when combining with the "Tab Sync" feature (by default ctrl+t + s): imagine re-running a few of these commands together by navigating to a tab that has all of them open (eg. with a layout) and just pressing
<ENTER>
.A short demo:
2022-10-10.20-09-19.mp4