-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SGR/UTF8 mouse reporting in terminal panes #1664
Conversation
@tlinford - if you could give this a spin to make sure I didn't break any mouse stuff that I'm not aware of that would be great :) @AutumnMeowMeow - if you have the time and feel like it, would you like to check this change out and let me know what you think? |
@imsnif Testing inside vttest, I see the following issues:
|
Thanks @AutumnMeowMeow ! I guess I was pretty tired when I submitted this. I even glanced over these in the tests :) All fixed. |
@imsnif It's better now, but I still see the following:
|
@AutumnMeowMeow - all fixed. These were part misunderstanding on my part, and part Zellij not previously fully supporting middle-clicks. Thanks again! |
@imsnif gave it a test, all of these seem fine to me:
|
I confirm normal-event and button-event are working correctly for me: simplescreenrecorder-2022-08-16_13.46.27.mp4Any-event is not yet working, so no tracking mouse cursor tracking, but that is expected. Click/drag/release and wheel-up/wheel-down are working well. I would say #1633 is fixed with this. :) |
Fantastic! Thank you both for your help. |
This is a fix for: #1633
Main changes:
There's room to implement AnyEvent tracking in supported terminals, but that's out of scope for this PR.