Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add checking for missing extensions #1432

Merged
merged 1 commit into from
May 24, 2022
Merged

fix: add checking for missing extensions #1432

merged 1 commit into from
May 24, 2022

Conversation

jaeheonji
Copy link
Member

@jaeheonji jaeheonji commented May 23, 2022

Fixes #1431

Under the circumstance of checking the existence of a layout file, the default assets are always loaded due to missing extensions.

@jaeheonji jaeheonji requested a review from a-kenji May 23, 2022 14:54
Copy link
Contributor

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
thank you for the quick fix!

@jaeheonji
Copy link
Member Author

jaeheonji commented May 24, 2022

@a-kenji Thank you for reviewing :)

@jaeheonji jaeheonji merged commit f7c0197 into zellij-org:main May 24, 2022
@jaeheonji jaeheonji deleted the fix-layout branch May 24, 2022 04:09
@raphCode
Copy link
Contributor

I think this commit slightly changed the behavior:
Previously, I had a layout file standard without file extension in the layout directory that I could load with zellij --layout standard.
This command now failed with IoError: The layout was not found, File: standard until I renamed the file to standard.yaml.

Not sure if I did something unusual but I feel we should mention the behavior change and fix (rename to .yaml) in the changelog?

@jaeheonji
Copy link
Member Author

I think the commit that changed the behavior is related to #1413 .

This commit is close to solving the problem that the existing function did not work properly because there was a missing part due to behavioral changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default layout is not loaded.
3 participants