Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tab): floating panes embed/fullscreen and frame color #1267

Merged
merged 2 commits into from
Mar 24, 2022
Merged

fix(tab): floating panes embed/fullscreen and frame color #1267

merged 2 commits into from
Mar 24, 2022

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Mar 24, 2022

This fixes two issues:

  1. (regression only in main) when a floating pane is focused the active tiled pane is no-longer colored as active
  2. when embedding a floated pane when a tiled pane is in fullscreen, it now behaves properly

@a-kenji a-kenji mentioned this pull request Mar 24, 2022
Merged
43 tasks
@imsnif imsnif temporarily deployed to cachix March 24, 2022 16:46 Inactive
@imsnif imsnif closed this Mar 24, 2022
@imsnif imsnif reopened this Mar 24, 2022
@imsnif imsnif temporarily deployed to cachix March 24, 2022 17:22 Inactive
@imsnif imsnif temporarily deployed to cachix March 24, 2022 17:22 Inactive
@imsnif imsnif temporarily deployed to cachix March 24, 2022 17:30 Inactive
@imsnif imsnif merged commit f5a3d8f into main Mar 24, 2022
@har7an har7an deleted the various-floating-panes-fixes branch October 23, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imsnif