Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Keybind for Returning to Previous Tab: #398

Closed
SaintFenix opened this issue Apr 28, 2021 · 3 comments · Fixed by #622
Closed

Feature: Keybind for Returning to Previous Tab: #398

SaintFenix opened this issue Apr 28, 2021 · 3 comments · Fixed by #622
Labels
action Issues related to actions ease of use Issues where zellij has clunky or difficult to use behaviours good first issue Good for newcomers

Comments

@SaintFenix
Copy link
Contributor

As part of #376 I'll be creating issues for missing tmux features for discussion for inclusion in Zellij, or overall improvement if Zellij's equivalent doesn't have as much functionality as Tmux.

This one is fairly simple.

A keybind in which will select the most recent tab you were on before the current one.

Basically Zellij could keep a history of what tabs you were on, and return you to the previous one.

It could be in Normal Mode, or Tab Mode, though I'd imagine it most useful in Normal Mode.

@a-kenji a-kenji added the action Issues related to actions label Apr 28, 2021
@khs26 khs26 added the ease of use Issues where zellij has clunky or difficult to use behaviours label May 9, 2021
@a-kenji a-kenji added the good first issue Good for newcomers label Jul 9, 2021
@sagittarius-a
Copy link
Contributor

Since it is labelled as a good first issue, I gave it a shot. I have a proof of concept working for this feature.

Before submitting a PR, I'd like to address few points regarding implementation:

  • What default keybinding to use ? I've considered Tab in Tab mode. If we implement this in Normal mode, what should be the associated keybinding ?
  • Do we use a toggle switch, i.e going backing and forth between the two last visited tabs, or we keep a list of visited tabs and we navigate through the list ? I've implemented the former since it felt more intuitive.

Thanks

@a-kenji
Copy link
Contributor

a-kenji commented Jul 21, 2021

Hey @sagittarius-a, that is awesome!

I think Tab in Tab mode is a good idea.
I am not sure if it makes much sense to bind it by default in the
Normal mode, but am open to more input on that.

I also think the former is more intuitive, and also what
most people would expect of such a feature.

Please do feel free to reach out if you have any more questions!

sagittarius-a added a commit to sagittarius-a/zellij that referenced this issue Jul 21, 2021
Fixes zellij-org#398.

Tab key is used as default for the `GoToLastTab` action.
@sagittarius-a
Copy link
Contributor

Alright PR is submitted.

I hope I did not forget something important. Any feedback appreciated :)

sagittarius-a added a commit to sagittarius-a/zellij that referenced this issue Jul 22, 2021
Fixes zellij-org#398.

Tab key is used as default for the `GoToLastTab` action.
sagittarius-a added a commit to sagittarius-a/zellij that referenced this issue Jul 23, 2021
Fixes zellij-org#398.

Tab key is used as default for the `GoToLastTab` action.
sagittarius-a added a commit to sagittarius-a/zellij that referenced this issue Jul 23, 2021
Fixes zellij-org#398.

Tab key is used as default for the `GoToLastTab` action.
sagittarius-a added a commit to sagittarius-a/zellij that referenced this issue Aug 3, 2021
Fixes zellij-org#398.

Tab key is used as default for the `GoToLastTab` action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action Issues related to actions ease of use Issues where zellij has clunky or difficult to use behaviours good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants