Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #1800

Merged
merged 13 commits into from
Mar 24, 2025
Merged

Misc fixes #1800

merged 13 commits into from
Mar 24, 2025

Conversation

hensldm
Copy link
Collaborator

@hensldm hensldm commented Mar 3, 2025

Some more misc fixes mostly revolving around disassembly, though a few other things.

Copy link
Collaborator

@AngheloAlf AngheloAlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is angry because of the new warnings

@AngheloAlf AngheloAlf removed the Needs-first-approval First approval label Mar 3, 2025
@hensldm hensldm marked this pull request as draft March 3, 2025 23:31
@hensldm hensldm marked this pull request as ready for review March 4, 2025 05:44
@AngheloAlf AngheloAlf added Merge-ready All reviewers satisfied, just waiting for CI and removed Needs-second-approval Second approval labels Mar 24, 2025
@AngheloAlf AngheloAlf merged commit 9ca02c7 into zeldaret:main Mar 24, 2025
1 check passed
@hensldm hensldm deleted the disasm_fix branch March 24, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean up Merge-ready All reviewers satisfied, just waiting for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants