suggestions #4
Merged
suggestions #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Jun 21, 2024
|
|
||
| /** | ||
| * This class is internal and is hence not for public use. Its APIs are unstable and can change at | ||
| * any time. | ||
| */ | ||
| public final class DefaultHttpClientTelemetryBuilder<REQUEST, RESPONSE> { | ||
| public final class DefaultHttpClientInstrumenterBuilder<REQUEST, RESPONSE> { |
There was a problem hiding this comment.
...InstrumenterBuilder because it builds an Instrumenter
trask
commented
Jun 21, 2024
Comment on lines
-48
to
+54
| private final Optional<TextMapSetter<REQUEST>> headerSetter; | ||
| private final HttpSpanNameExtractorBuilder<REQUEST> httpSpanNameExtractorBuilder; | ||
|
|
||
| @Nullable private TextMapSetter<REQUEST> headerSetter; | ||
| private Function<SpanNameExtractor<REQUEST>, ? extends SpanNameExtractor<? super REQUEST>> | ||
| spanNameExtractorTransformer = Function.identity(); | ||
| private boolean emitExperimentalHttpClientMetrics = false; | ||
| private Consumer<InstrumenterBuilder<REQUEST, RESPONSE>> builderCustomizer = b -> {}; |
There was a problem hiding this comment.
moved these to optional fields with associated normal builder pattern setters to keep the constructor and build() methods limited to required fields
zeitlinger
merged commit 6a42292
into
zeitlinger:insrumentation-builder-factory
47 of 54 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.