error.type and db.response.status_code all dbs

zeitlinger · Feb 24, 2025 · b33510e · b33510e
1 parent 7454b42
commit b33510e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/instrumentation/vertx/vertx-sql-client-4.0/javaagent/build.gradle.kts b/instrumentation/vertx/vertx-sql-client-4.0/javaagent/build.gradle.kts
@@ -13,7 +13,6 @@ muzzle {
 
 dependencies {
   library("io.vertx:vertx-sql-client:4.0.0")
-  compileOnly("io.vertx:vertx-pg-client:4.0.0")
   compileOnly("io.vertx:vertx-codegen:4.0.0")
 
   testInstrumentation(project(":instrumentation:netty:netty-4.1:javaagent"))

diff --git a/...pentelemetry/javaagent/instrumentation/vertx/v4_0/sql/VertxSqlClientAttributesGetter.java b/...pentelemetry/javaagent/instrumentation/vertx/v4_0/sql/VertxSqlClientAttributesGetter.java
@@ -8,7 +8,7 @@
 import static java.util.Collections.singleton;
 
 import io.opentelemetry.instrumentation.api.incubator.semconv.db.SqlClientAttributesGetter;
-import io.vertx.pgclient.PgException;
+import java.lang.reflect.InvocationTargetException;
 import java.util.Collection;
 import javax.annotation.Nullable;
 
@@ -49,8 +49,16 @@ public Collection<String> getRawQueryTexts(VertxSqlClientRequest request) {
   @Nullable
   @Override
   public String getResponseStatusFromException(Throwable throwable) {
-    if (throwable instanceof PgException) {
-      return ((PgException) throwable).getCode();
+    try {
+      Class<?> ex = Class.forName("io.vertx.pgclient.PgException");
+      if (ex.isInstance(throwable)) {
+        return (String) ex.getMethod("getCode").invoke(throwable);
+      }
+    } catch (ClassNotFoundException
+        | NoSuchMethodException
+        | IllegalAccessException
+        | InvocationTargetException e) {
+      return null;
     }
     return null;
   }