Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SCSI] mvsas: fix undefined bit shift
The macro bit(n) is defined as ((u32)1 << n), and thus it doesn't work with n >= 32, such as in mvs_94xx_assign_reg_set(): if (i >= 32) { mvi->sata_reg_set |= bit(i); ... } The shift ((u32)1 << n) with n >= 32 also leads to undefined behavior. The result varies depending on the architecture. This patch changes bit(n) to do a 64-bit shift. It also simplifies mv_ffc64() using __ffs64(), since invoking ffz() with ~0 is undefined. Signed-off-by: Xi Wang <[email protected]> Acked-by: Xiangliang Yu <[email protected]> Cc: [email protected] Signed-off-by: James Bottomley <[email protected]>
- Loading branch information