Skip to content

Commit

Permalink
libata: set dma_mode to 0xff in reset
Browse files Browse the repository at this point in the history
ata_device->dma_mode's initial value is zero, which is not a valid dma
mode, but ata_dma_enabled will return true for this value. This patch
sets dma_mode to 0xff in reset function, so that ata_dma_enabled will
not return true for this case, or it will cause problem for pata_acpi.

The corrsponding bugzilla page is at:
https://bugzilla.kernel.org/show_bug.cgi?id=49151

Reported-by: Phillip Wood <[email protected]>
Signed-off-by: Aaron Lu <[email protected]>
Tested-by: Szymon Janc <[email protected]>
Tested-by: Dutra Julio <[email protected]>
Acked-by: Alan Cox <[email protected]>
Cc: <[email protected]>
Signed-off-by: Jeff Garzik <[email protected]>
  • Loading branch information
Aaron Lu authored and Jeff Garzik committed Dec 3, 2012
1 parent f295be2 commit 5416912
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/ata/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2559,6 +2559,7 @@ int ata_bus_probe(struct ata_port *ap)
* bus as we may be talking too fast.
*/
dev->pio_mode = XFER_PIO_0;
dev->dma_mode = 0xff;

/* If the controller has a pio mode setup function
* then use it to set the chipset to rights. Don't
Expand Down
1 change: 1 addition & 0 deletions drivers/ata/libata-eh.c
Original file line number Diff line number Diff line change
Expand Up @@ -2657,6 +2657,7 @@ int ata_eh_reset(struct ata_link *link, int classify,
* bus as we may be talking too fast.
*/
dev->pio_mode = XFER_PIO_0;
dev->dma_mode = 0xff;

/* If the controller has a pio mode setup function
* then use it to set the chipset to rights. Don't
Expand Down

0 comments on commit 5416912

Please sign in to comment.