Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

probes: correctly check if a pod is targeted by a service #318

Merged
merged 1 commit into from
Oct 2, 2020
Merged

probes: correctly check if a pod is targeted by a service #318

merged 1 commit into from
Oct 2, 2020

Conversation

zegl
Copy link
Owner

@zegl zegl commented Oct 2, 2020 •
edited
Loading

Previously only one label needed to match and not all, causing false positives

RELNOTE: Fix a bug in the "Pod Probes" test where a Pod could incorrectly be considered to be targeted by a Service

This fixes #316

@zegl
probes: correctly check if a pod is targeted by a service
cb0fbf6 
Previously only one label needed to match and not all, causing false positives
@zegl
Copy link
Owner Author

zegl commented Oct 2, 2020

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 2, 2020

Build succeeded:

@bors bors bot merged commit 0f5c694 into master Oct 2, 2020
@bors bors bot deleted the pod-targeted-by-service branch October 2, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

readinessProbe false positive when a pod matches partially service selector
1 participant
@zegl