decode: reject strings with negative length #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Would you mind adding yourself to AUTHORS? Also do you agree to license this contribution under the terms in the LICENSE file? |
| @@ -79,6 +79,7 @@ func TestDecode(t *testing.T) { | |||
| {`di5ei2ee`, new(interface{}), nil, true}, | |||
| {`d3:fooe`, new(interface{}), nil, true}, | |||
| {`l3:foo3:bar`, new(interface{}), nil, true}, | |||
| {`d3:000d3:000ld-6:`, new(interface{}), nil, true}, | |||
There was a problem hiding this comment.
also i believe d-1: is a shorter test case that exhibits the same bug. this only affects strings as keys in a dictionary because top level strings get dispatched by the presence of a number, and - doesn't work.
Found running go-fuzz.
pmezard
force-pushed
the
fix-decoding-error
branch
from
6312312
to
b49e5f9
Compare
|
PTAL |
zeebo
added a commit
that referenced
this pull request
Aug 18, 2015
decode: reject strings with negative length
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found running go-fuzz.