Investigate flaky test: test_layout_str - #86
Closed
nathansobo wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Closing this for now since we've implemented a workaround in #94 and this isn't a super high priority. |
ascarter
pushed a commit
to ascarter/zed
that referenced
this pull request
Jan 15, 2025
* Remove output editor * Implement output grouping * Remove OutputGroup when we found the end position * Fix make gutter smaller * Render placeholder * Show group end on the same level as group start * Add tests * Add support for collapsed grouped output * Fix crease placeholder is not showing up * Don't trim output multiple times * Update tests * Fix clippy
Bombfuse
pushed a commit
to gemdropgames/zed
that referenced
this pull request
Aug 10, 2026
Conditional GGO_EMD hint (lookup failures only, not CLI drift), now that worldlib's Missing text is host-neutral (ggo zed-industries#86). MIGRATION re-tally: seven rows moved, 44/34/15/11. UPSTREAM: F5.3 measurements + drill zed-industries#9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #85
I've added some more assertions to the test to try to understand what's going on here. Hopefully I can reproduce the flake with actions.