Unify language model event stream handling - #63520
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
anantdgoel
reviewed
Sep 2, 2026
anantdgoel
approved these changes
Sep 2, 2026
MrSubidubi
enabled auto-merge
September 2, 2026 15:31
whitecat1331
pushed a commit
to whitecat1331/zed
that referenced
this pull request
Sep 3, 2026
Closes zed-industries#63314 Closes zed-industries#42584 Follow-up to zed-industries#62652 Removes a lot of duplicated code in favor of throwing it into`language_core` as well as removing duplicate struct definitions that were only different because of entirely unused fields. Furthermore, improves error-messages so that these untagged enum errors are no longer a thing in an effort to make this more maintainable in the future. Lastly, includes a small but nice improvement changing a `Value` to a `RawValue` so that we don't have to clone for deserialization in that specific case. Release Notes: - Improved streaming for OpenAI-compatible providers. --------- Co-authored-by: Anant Goel <anant@zed.dev>
JannikRosendahl
pushed a commit
to JannikRosendahl/zed
that referenced
this pull request
Sep 6, 2026
Closes zed-industries#63314 Closes zed-industries#42584 Follow-up to zed-industries#62652 Removes a lot of duplicated code in favor of throwing it into`language_core` as well as removing duplicate struct definitions that were only different because of entirely unused fields. Furthermore, improves error-messages so that these untagged enum errors are no longer a thing in an effort to make this more maintainable in the future. Lastly, includes a small but nice improvement changing a `Value` to a `RawValue` so that we don't have to clone for deserialization in that specific case. Release Notes: - Improved streaming for OpenAI-compatible providers. --------- Co-authored-by: Anant Goel <anant@zed.dev>
HalavicH
pushed a commit
to HalavicH/zed
that referenced
this pull request
Sep 8, 2026
Closes zed-industries#63314 Closes zed-industries#42584 Follow-up to zed-industries#62652 Removes a lot of duplicated code in favor of throwing it into`language_core` as well as removing duplicate struct definitions that were only different because of entirely unused fields. Furthermore, improves error-messages so that these untagged enum errors are no longer a thing in an effort to make this more maintainable in the future. Lastly, includes a small but nice improvement changing a `Value` to a `RawValue` so that we don't have to clone for deserialization in that specific case. Release Notes: - Improved streaming for OpenAI-compatible providers. --------- Co-authored-by: Anant Goel <anant@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63314
Closes #42584
Follow-up to #62652
Removes a lot of duplicated code in favor of throwing it into
language_coreas well as removing duplicate struct definitions that were only different because of entirely unused fields.Furthermore, improves error-messages so that these untagged enum errors are no longer a thing in an effort to make this more maintainable in the future.
Lastly, includes a small but nice improvement changing a
Valueto aRawValueso that we don't have to clone for deserialization in that specific case.Release Notes: