git_ui: Hide staged section when no files are staged - #62397
Closed
hexadecimal233 wants to merge 1 commit into
Closed
git_ui: Hide staged section when no files are staged#62397hexadecimal233 wants to merge 1 commit into
hexadecimal233 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR, but I don't see a good reason to do this and the mentioned PR that introduced this ( #60976 ), did so intentionally.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Introduced in #60976, there is now a placeholder showing all the time in the Git Panel when there is no staged files, so the "Stage all" button is placed below the Staged section.
When Staging all files, the OG cursor position often hovers on 2nd/3rd item which might lead to bad UX design.
Solution
Testing
Self-Review Checklist:
Showcase
Click to view showcase
Before:After:

Release Notes: