docs: Rename brand-voice to brand-writer skill

[bechor25]

What

docs/.conventions/brand-voice/SKILL.md declares:

name: brand-writer

while sitting in a directory called brand-voice.

The Agent Skills specification requires the two to be identical:

The required name field: … Must match the parent directory name
— https://agentskills.io/specification#name-field

So this skill fails skills-ref validate today.

Which side is wrong

The directory — and this repository settles it three separate ways, with no outside context needed.

1. The sibling copy already uses the matching name. .factory/skills/brand-writer/ holds the same four files (SKILL.md, rubric.md, taboo-phrases.md, voice-examples.md) under brand-writer.

2. crates/agent_skills/README.md documents the skill system using this exact skill, and the name it documents is brand-writer:

line 107:  <name>brand-writer</name>
line 149:  the model … calls `skill { name: "brand-writer" }`
line 151:  when the user types `/brand-writer`
line 158:  <skill_content name="brand-writer">

That name is load-bearing — it is what the skill tool invokes and what the slash command types. The directory name is referenced twice, both inside docs/.conventions/CONVENTIONS.md.

3. Six of the repository's seven skills already match their directory:

skill	matches?
.agents/skills/gpui-test	✅
.agents/skills/lint-creator	✅
.agents/skills/zed-cherry-pick	✅
.factory/skills/brand-writer	✅
.factory/skills/humanizer	✅
crates/agent_skills/builtin/create-skill	✅
docs/.conventions/brand-voice	❌ the only one

The change

The frontmatter is untouched. Only the directory moves, plus the two references to it:

• docs/.conventions/brand-voice/ → docs/.conventions/brand-writer/ (4 files, pure rename)
• CONVENTIONS.md:5 — [brand-voice/](./brand-voice/) → [brand-writer/](./brand-writer/)
• CONVENTIONS.md:368 — `brand-voice/rubric.md` → `brand-writer/rubric.md`

git grep brand-voice returns nothing afterwards.

If you would rather keep the directory name and rename the field to brand-voice, that is a one-line change instead and I am happy to switch it — but it would give the two copies of one skill two different names, and it would diverge from the name crates/agent_skills/README.md documents.

One thing I noticed but did not touch

The two copies have drifted. .factory/skills/brand-writer/SKILL.md is 279 lines and includes a "Phase 4: Humanizer Pass" section; docs/.conventions/'s copy is 265 lines, lacks that section, and renumbers Validation from Phase 5 to Phase 4. That is a separate question about which copy is canonical, so it is left alone here.

---

Found with AgentCompass, an offline static analyzer for AI-agent repo readiness. Verified by hand against the spec before opening.

Release Notes:

• N/A

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @bechor25 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[dinocosta]

Thanks @bechor25 ! I believe we do want to keep it consistent with the existing .factory/skills/brand-writer 🙂

However, we need you to sign the CLA before we're able to approve and merge these changes. Thanks!

[bechor25]

@cla-bot check

[cla-bot]

We require contributors to sign our Contributor License Agreement, and we don't have @bechor25 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[bechor25]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[bechor25]

@dinocosta CLA is signed and the check is green now (verification/cla-signed: success), so this should be unblocked on that front.

Two things left that need someone with write access:

• run_bundling and nix_build are sitting at action_required — first-time fork contributor, so they need an "Approve and run workflows" click before they'll start.
• The review is still CHANGES_REQUESTED from the CLA hold.

And thanks for confirming the direction — keeping it consistent with .factory/skills/brand-writer is exactly what this does. The frontmatter is untouched; only the directory moves, along with the two references to it in docs/.conventions/CONVENTIONS.md. No rush at all, just flagging since it's waiting on your side.

[dinocosta]

Thanks! 🙂