node_runtime: Bound managed npm cache growth - #61428
Closed
AlisinaDevelo wants to merge 1 commit into
Closed
Conversation
Install registry npm agents into stable per-agent prefixes so version updates replace the prior dependency tree. Use temporary download caches for those installs and reclaim legacy npm caches once. Refs zed-industries#59409
Author
|
Hey, just checking in on the npm cache change—does this need anything else from me to move forward? |
|
Hey @AlisinaDevelo #61750 I think this PR fixed this issue, I am not sure as I am not a rust dev. Just for your info ^ |
Contributor
|
Sorry: apparently, the PR was overlooked as never left the draft status and, as mentioned, another one was created to fix the issue. Will close this one as the fix is merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
_npxand_cacachedirectories once, preserving unrelated cache contents such as npm logs.Testing
cargo test -p node_runtime(23 tests passed)cargo check -p projectcargo clippy -p node_runtime --all-targets -- -D warningscargo clippy -p project -- -D warnings_npxenvironments.Linux and Windows were not manually tested.
Self-Review Checklist:
Release Notes: