thread_view: Only show thread controls at the end of the turn - #61362
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
kubkon
reviewed
Jul 20, 2026
kubkon
approved these changes
Jul 20, 2026
danilo-leal
enabled auto-merge
July 20, 2026 20:28
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…dustries#61362) Follow up to zed-industries#61245. That PR introduced a bug where the thread controls would appear at seemingly random tool boundaries as opposed to only at the end of each turn. It caused this sort of behavior, where we'd have many instances of those buttons showing up: <img width="500" alt="Screenshot 2026-07-20 at 4 03 2@2x" src="https://github.com/user-attachments/assets/6e6f716e-adb5-4532-9f89-e955398cda23" /> Alongside with fixing it, this PR is also making the "scroll to top" only show up only at the very last turn. I think that makes more sense given you'd be most likely interested to go to the top when you're at the bottom, rather than at every turn, but I could be persuaded otherwise; not holding that too strongly. Release Notes: - N/A
playdohface
pushed a commit
to playdohface/zed
that referenced
this pull request
Aug 29, 2026
…dustries#61362) Follow up to zed-industries#61245. That PR introduced a bug where the thread controls would appear at seemingly random tool boundaries as opposed to only at the end of each turn. It caused this sort of behavior, where we'd have many instances of those buttons showing up: <img width="500" alt="Screenshot 2026-07-20 at 4 03 2@2x" src="https://github.com/user-attachments/assets/6e6f716e-adb5-4532-9f89-e955398cda23" /> Alongside with fixing it, this PR is also making the "scroll to top" only show up only at the very last turn. I think that makes more sense given you'd be most likely interested to go to the top when you're at the bottom, rather than at every turn, but I could be persuaded otherwise; not holding that too strongly. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #61245. That PR introduced a bug where the thread controls would appear at seemingly random tool boundaries as opposed to only at the end of each turn. It caused this sort of behavior, where we'd have many instances of those buttons showing up:
Alongside with fixing it, this PR is also making the "scroll to top" only show up only at the very last turn. I think that makes more sense given you'd be most likely interested to go to the top when you're at the bottom, rather than at every turn, but I could be persuaded otherwise; not holding that too strongly.
Release Notes: