Skip to content

editor: Fix opaque multibuffer header backgrounds not rendering in transparent themes #61268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristopherBiscardi merged 1 commit into from
Jul 20, 2026
Merged

editor: Fix opaque multibuffer header backgrounds not rendering in transparent themes #61268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/editor/src/element/header.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,11 +685,12 @@ pub(crate) fn render_buffer_header(
};
let focus_handle = editor_read.focus_handle(cx);
let colors = cx.theme().colors();
// On transparent windows `editor_subheader_background` stacks over the
// editor background into a darker bar (and the sticky shadow becomes a halo),
// so skip both unless the window is opaque.
// On transparent windows, only render an opaque `editor_subheader_background` so it masks
// the editor content beneath it without creating a darker bar. Sticky shadows still require
// an opaque window to avoid rendering as a halo.
let opaque_window =
cx.theme().window_background_appearance() == WindowBackgroundAppearance::Opaque;
let show_header_background = opaque_window || colors.editor_subheader_background.is_opaque();

let show_open_file_button =
can_open_excerpts && relative_path.is_some() && (is_selected || header_hovered);
Expand Down Expand Up @@ -727,7 +728,9 @@ pub(crate) fn render_buffer_header(
border.border_color(border_color)
})
.when(is_sticky && opaque_window, |s| s.shadow_md())
.when(opaque_window, |s| s.bg(colors.editor_subheader_background))
.when(show_header_background, |s| {
s.bg(colors.editor_subheader_background)
})
.hover(|s| s.bg(colors.element_hover))
.map(|header| {
let editor = editor.clone();
Expand Down
Loading