agent: Treat empty spawn_agent session IDs as new sessions - #60902
Closed
haotian467 wants to merge 5 commits into
Closed
agent: Treat empty spawn_agent session IDs as new sessions#60902haotian467 wants to merge 5 commits into
haotian467 wants to merge 5 commits into
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @haotian467 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Member
|
This was added in #60893 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
spawn_agentuses an optionalsession_idto distinguish between creating a new session and resuming an existing one:Nonecreates a new session.In some model tool-call paths, a JSON
nullsession ID is serialized as an empty string. Because an empty string still deserializes asSome(SessionId("")),spawn_agentattempts to resume that session and fails with:cargo fmt --all -- --check.git diff --check.Self-Review Checklist:
Release Notes:
spawn_agentfailing to create a new sub-agent session when its session ID was serialized as an empty string.