terminal: Start a selection on shift+drag when mouse tracking is active - #60880
Merged
ChristopherBiscardi merged 1 commit intoJul 20, 2026
Merged
Conversation
Shift is the escape hatch to select text while an app grabs the mouse, but shift+click only extended an existing selection, so a fresh drag had no anchor to work from and selected nothing.
cla-bot
Bot
added
the
cla-signed
SomeoneToIgnore
added
the
area:integrations/terminal
This was referenced Jul 31, 2026
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ve (zed-industries#60880) run htop or btm and you can't select terminal text with shift+drag, the usual escape hatch does nothing. zed-industries#25143 made shift+click only ever extend a selection, never start one. so with nothing selected there's no anchor and the drag has nothing to grab. now it drops an anchor when there's no selection, and still extends when there is. added two event-level tests (harness can't sync without a window): shift+drag under mouse tracking, which fails without the fix, and shift+click still extending. Fixes zed-industries#60254. Release Notes: - Fixed Shift+click-drag not selecting terminal text while an app has mouse tracking enabled
This was referenced Aug 25, 2026
playdohface
pushed a commit
to playdohface/zed
that referenced
this pull request
Aug 29, 2026
…ve (zed-industries#60880) run htop or btm and you can't select terminal text with shift+drag, the usual escape hatch does nothing. zed-industries#25143 made shift+click only ever extend a selection, never start one. so with nothing selected there's no anchor and the drag has nothing to grab. now it drops an anchor when there's no selection, and still extends when there is. added two event-level tests (harness can't sync without a window): shift+drag under mouse tracking, which fails without the fix, and shift+click still extending. Fixes zed-industries#60254. Release Notes: - Fixed Shift+click-drag not selecting terminal text while an app has mouse tracking enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run htop or btm and you can't select terminal text with shift+drag, the usual escape hatch does nothing.
#25143 made shift+click only ever extend a selection, never start one. so with nothing selected there's no anchor and the drag has nothing to grab. now it drops an anchor when there's no selection, and still extends when there is.
added two event-level tests (harness can't sync without a window): shift+drag under mouse tracking, which fails without the fix, and shift+click still extending.
Fixes #60254.
Release Notes: