Skip to content

csv_preview: #6 Refine row filtering UI - #60676

Closed
HalavicH wants to merge 15 commits into
zed-industries:mainfrom
HalavicH:feat/csv-preview/row-filtering-ui-refinement
Closed

csv_preview: #6 Refine row filtering UI#60676
HalavicH wants to merge 15 commits into
zed-industries:mainfrom
HalavicH:feat/csv-preview/row-filtering-ui-refinement

Conversation

@HalavicH

@HalavicH HalavicH commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Objective

Improve UI of row filtering (icons & popup), add intuitive controls, search among options.
Filter icons improvement

A bugfix of bug showing incorrect number of occurances when multiple filters were stacked together

Solution

Implemented popover with variable height list which shows filter options with checked/unchecked status and counts.
Grows automatically up to 60% viewport height, after - scrollbar appears

Testing

Tested using few fixtures: single line, multiline
With long and short list of entries (scrolling)
With multiple filters stacked together (filter chain)
No platform specific changes

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Showcase

Before:

image

After:

First filter application
image

Second filter application
image

Search in filter
image

Tooltip over cell which allow to copy content
image


Release Notes:

  • Refined CSV preview UI

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jul 9, 2026
@HalavicH
HalavicH marked this pull request as ready for review July 10, 2026 08:13
@dinocosta dinocosta added the area:preview/csv Feedback for Zed's CSV support label Jul 10, 2026
@HalavicH HalavicH changed the title csv_preview: Refine row filtering UI csv_preview: #6 Refine row filtering UI Jul 13, 2026
@HalavicH

Copy link
Copy Markdown
Contributor Author

Closing as it was split into #60995 #61127 #61138 #61769 #61796

@HalavicH HalavicH closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:preview/csv Feedback for Zed's CSV support cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants