csv_preview: #6 Refine row filtering UI - #60676
Closed
HalavicH wants to merge 15 commits into
Closed
Conversation
HalavicH
marked this pull request as ready for review
July 10, 2026 08:13
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Improve UI of row filtering (icons & popup), add intuitive controls, search among options.
Filter icons improvement
A bugfix of bug showing incorrect number of occurances when multiple filters were stacked together
Solution
Implemented popover with variable height list which shows filter options with checked/unchecked status and counts.
Grows automatically up to 60% viewport height, after - scrollbar appears
Testing
Tested using few fixtures: single line, multiline
With long and short list of entries (scrolling)
With multiple filters stacked together (filter chain)
No platform specific changes
Self-Review Checklist:
Showcase
Before:
After:
First filter application

Second filter application

Search in filter

Tooltip over cell which allow to copy content

Release Notes: