Handle SSE data fields without spaces - #60575
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
dinocosta
requested changes
Jul 8, 2026
dinocosta
left a comment
dinocosta
left a comment
Member
There was a problem hiding this comment.
Thank you for tackling this @justjavac !
Change looks good but left a couple of comments on things I believe we could improve before shipping 🙂
Contributor
Author
|
Addressed both review comments in adcad63: simplified the SSE data field parser and expanded the regression test to cover both |
Member
Thank you @justjavac ! ✌️ |
dinocosta
approved these changes
Jul 8, 2026
dinocosta
enabled auto-merge
July 8, 2026 17:08
bennetbo
added
the
area:ai
AtlantisPleb
pushed a commit
to OpenAgentsInc/omega
that referenced
this pull request
Jul 30, 2026
Fixes zed-industries#60270. ## Summary - Accept MCP HTTP SSE `data:` fields when the optional space after the colon is omitted. - Add a regression test covering `data:{...}` streamable HTTP responses. ## Tests - `cargo fmt --check` - `cargo test -p context_server test_sse_data_field_without_space_after_colon -- --nocapture` - `cargo test -p context_server -- --nocapture` Release Notes: - Fixed MCP HTTP context servers timing out when SSE data fields omit the optional space after the colon. --------- Co-authored-by: dino <dinojoaocosta@gmail.com> (cherry picked from commit 007ffc7)
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Fixes zed-industries#60270. ## Summary - Accept MCP HTTP SSE `data:` fields when the optional space after the colon is omitted. - Add a regression test covering `data:{...}` streamable HTTP responses. ## Tests - `cargo fmt --check` - `cargo test -p context_server test_sse_data_field_without_space_after_colon -- --nocapture` - `cargo test -p context_server -- --nocapture` Release Notes: - Fixed MCP HTTP context servers timing out when SSE data fields omit the optional space after the colon. --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
playdohface
pushed a commit
to playdohface/zed
that referenced
this pull request
Aug 29, 2026
Fixes zed-industries#60270. ## Summary - Accept MCP HTTP SSE `data:` fields when the optional space after the colon is omitted. - Add a regression test covering `data:{...}` streamable HTTP responses. ## Tests - `cargo fmt --check` - `cargo test -p context_server test_sse_data_field_without_space_after_colon -- --nocapture` - `cargo test -p context_server -- --nocapture` Release Notes: - Fixed MCP HTTP context servers timing out when SSE data fields omit the optional space after the colon. --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60270.
Summary
data:fields when the optional space after the colon is omitted.data:{...}streamable HTTP responses.Tests
cargo fmt --checkcargo test -p context_server test_sse_data_field_without_space_after_colon -- --nocapturecargo test -p context_server -- --nocaptureRelease Notes: