gpui_windows: Fix window drag repositioning - #60064
Closed
Prohect wants to merge 3 commits into
Closed
Conversation
Return HTCAPTION from WM_NCHITTEST for Drag areas when using a custom titlebar, so Windows can handle the drag natively via DefWindowProcW - regardless of the is_movable flag. Commit 9ac1176 ("Fix immovable windows skipping hit testing") changed Drag to only return HTCAPTION when is_movable is true, but Zed's main window has is_movable set to false for macOS compatibility. This caused the title bar to become undraggable on Windows. Also suppress a spurious error log from ImmNotifyIME that could report ERROR_SUCCESS (0x00000000) as an error. Closes zed-industries#58521
cla-bot
Bot
added
the
cla-signed
Contributor
Author
|
this bug is recently introduced to the Nightly verison. It doesnt exist on the newest release version nor the newest preview version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return
HTCAPTIONfromWM_NCHITTESTforDragareas when using a custom titlebar, so Windows can handle the drag natively viaDefWindowProcW— regardless of theis_movableflag.Commit 9ac1176 ("Fix immovable windows skipping hit testing") changed
Dragto only returnHTCAPTIONwhenis_movableis true, but Zed's main window hasis_movableset to false for macOS compatibility. This caused the title bar to become undraggable on Windows.Also suppress a spurious error log from
ImmNotifyIMEthat could reportERROR_SUCCESS(0x00000000) as an error.Closes #58521
https://youtu.be/uARmzk7ocyE
Release Notes: