Emit agent thread status change events - #60057
Merged
benbrandt merged 1 commit intoJun 29, 2026
Merged
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: David Scarpetti.
|
dscarpetti
force-pushed
the
fix-agent-status-updates
branch
from
June 29, 2026 01:19
65b2aed to
be653b7
Compare
benbrandt
enabled auto-merge
June 29, 2026 09:15
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
# Objective Fix unreliable working/status indicators for ACP agent threads. ACP threads update their internal running state when a turn starts, completes, or is canceled, but those status-only changes were not being emitted as thread events. The agent UI could miss transitions unless another entry-related event happened nearby, making it particularly hard to monitor the status of multiple agent threads running at once. Hope this helps, and thanks for making Zed. ## Solution - Add an `AcpThreadEvent::StatusChanged` event. - Emit it when `running_turn` is set, cleared, or canceled. - Have `ConversationView` handle the event by syncing the active thread view's generating indicator. - Treat status changes as UI state only, not root thread metadata changes. ## Testing - `cargo check -p sidebar -p project -p git_ui -p workspace` - Manually verified in a local dev build on macOS that ACP agent status/working indicators update reliably. No automated test was added; this changes UI synchronization for ACP thread status events. ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable --- Release Notes: - Fixed unreliable working indicators for ACP agent threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix unreliable working/status indicators for ACP agent threads.
ACP threads update their internal running state when a turn starts, completes, or is canceled, but those status-only changes were not being emitted as thread events. The agent UI could miss transitions unless another entry-related event happened nearby, making it particularly hard to monitor the status of multiple agent threads running at once.
Hope this helps, and thanks for making Zed.
Solution
AcpThreadEvent::StatusChangedevent.running_turnis set, cleared, or canceled.ConversationViewhandle the event by syncing the active thread view's generating indicator.Testing
cargo check -p sidebar -p project -p git_ui -p workspaceNo automated test was added; this changes UI synchronization for ACP thread status events.
Self-Review Checklist:
Release Notes: