Fix window dragging on Windows - #60038
Closed
lingyaochu wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
oh, just noticed another PR #59967 already exsists, closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Recently, a bug was introduced in the Windows nightly builds where the Zed window cannot be dragged around. The preview build does not have this issue. By checking out commits between these two builds and testing them (a manual binary search), I identified that #59836 introduced this regression.
According to the PR description of #59836, the change was intended to fix a macOS-specific issue by setting
is_movabletofalse. However, this change had the side effect of breaking window dragging on Windows.Solution
Make the
is_movableconfiguration platform-dependent: keep itfalseon macOS to preserve the fix, but keep ittrueon Windows and other platforms.Testing
Manually tested the fix locally on Windows, and the window can now be dragged normally.
Self-Review Checklist:
Release Notes: