Skip to content

Fix window dragging on Windows - #60038

Closed
lingyaochu wants to merge 1 commit into
zed-industries:mainfrom
lingyaochu:windows-drag
Closed

Fix window dragging on Windows#60038
lingyaochu wants to merge 1 commit into
zed-industries:mainfrom
lingyaochu:windows-drag

Conversation

@lingyaochu

@lingyaochu lingyaochu commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Objective

Recently, a bug was introduced in the Windows nightly builds where the Zed window cannot be dragged around. The preview build does not have this issue. By checking out commits between these two builds and testing them (a manual binary search), I identified that #59836 introduced this regression.

According to the PR description of #59836, the change was intended to fix a macOS-specific issue by setting is_movable to false. However, this change had the side effect of breaking window dragging on Windows.

Solution

Make the is_movable configuration platform-dependent: keep it false on macOS to preserve the fix, but keep it true on Windows and other platforms.

Testing

Manually tested the fix locally on Windows, and the window can now be dragged normally.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed the Zed window could not be dragged on Windows.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 28, 2026
@zed-community-bot zed-community-bot Bot added community champion Issues filed by our amazing community champions! 🫶 guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions labels Jun 28, 2026
@lingyaochu

Copy link
Copy Markdown
Collaborator Author

oh, just noticed another PR #59967 already exsists, closing this

@lingyaochu lingyaochu closed this Jun 28, 2026
@lingyaochu
lingyaochu deleted the windows-drag branch June 29, 2026 11:06
@zelenenka zelenenka removed the guild Pull requests by someone in Zed Guild. NOTE: the label application is automated via github actions label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants