settings_ui: Remove feature flag for AI settings and adjust design - #59860
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
|
@zed-industries/approved |
| let restart_button = matches!( | ||
| connection_status, | ||
| AgentConnectionStatus::Connected | AgentConnectionStatus::Connecting | ||
| ) | ||
| .then(|| { | ||
| IconButton::new( | ||
| SharedString::from(format!("restart-{}", id)), | ||
| IconName::RotateCw, | ||
| ) | ||
| .disabled(connection_status == AgentConnectionStatus::Connecting) | ||
| .icon_color(Color::Muted) | ||
| .icon_size(IconSize::Small) | ||
| .tooltip(Tooltip::text("Restart Agent Connection")) | ||
| .on_click(cx.listener({ | ||
| let agent = agent.clone(); | ||
| move |this, _, _window, cx| { | ||
| let server: Rc<dyn agent_servers::AgentServer> = | ||
| Rc::new(agent_servers::CustomAgentServer::new(agent.id())); | ||
| this.agent_connection_store.update(cx, |store, cx| { | ||
| store.restart_connection(agent.clone(), server, cx); | ||
| }); | ||
| } | ||
| })) | ||
| }); |
There was a problem hiding this comment.
As I discovered in the latest preview build, it looks like this PR removes the restart button for external agents completely, is there any plan to bring this back in the new UI? I found this button quite useful for picking up settings file changes, after upgrading an external agent, etc. Also very useful when building / scripting ACP tools to pick up changes.
Alternatively, is there a different way to restart the agent server I'm missing, other than restarting Zed completely? I couldn't find anything in the command palette or anything like that.
(also, I'm not sure what's the best way to raise questions like this, hence the PR comment — should feature regressions like this be reported as a bug? Raised as a new feature request via discussions? Something else?)
There was a problem hiding this comment.
Yes, now i have to go to settings, cant change directly in the chat to configure things
There was a problem hiding this comment.
I think we might have accidentally removed this button, will double-check and add it back
Alternatively, is there a different way to restart the agent server I'm missing, other than restarting Zed completely? I couldn't find anything in the command palette or anything like that.
For now you can still restart an ACP server from the logs view. Run dev: open acp logs, select the ACP agent you want to restart, and click on the restart button
…ed-industries#59860) Closes AI-159 Closes AI-434 Closes AI-435 Release Notes: - Key agent-related settings now live in the settings editor, close to all other settings available in Zed. This specifically includes the move of LLM providers, external agents, and MCP servers to the settings editor. --------- Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com> Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
4 participants
Closes AI-159
Closes AI-434
Closes AI-435
Release Notes: