markdown: Add debug_asserts for search result ordering - #59483
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
bennetbo
changed the title
zed-community-bot
Bot
added
the
staff
bennetbo
force-pushed
the
markdown-optimize-paint-highlights
branch
from
June 17, 2026 14:15
232b2d3 to
f644cee
Compare
Veykril
approved these changes
Jun 17, 2026
This was referenced Jun 18, 2026
Closed
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…s#59483) Follow up to zed-industries#59473 The previous code could actually highlight the wrong match if you passed in unordered ranges. However, i realized that all codepaths are passing in ordered matches already, so I just added some `debug_asserts` to ensure that this is always the case. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #59473
The previous code could actually highlight the wrong match if you passed in unordered ranges.
However, i realized that all codepaths are passing in ordered matches already, so I just added some
debug_assertsto ensure that this is always the case.Release Notes: