agent: Account for max_output_tokens in compaction threshold - #59469
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Member
Author
|
/cherry-pick preview |
Contributor
|
|
zed-zippy
Bot
added
the
PR state:needs review
zed-zippy Bot
added a commit
that referenced
this pull request
Jun 17, 2026
… (cherry-pick to preview) (#59475) Cherry-pick of #59469 to preview ---- Follow up to #58883 This makes sure that we subtract the max output tokens before checking the threshold for auto compaction was reached, we had that logic before #58883 but we lost it when introducing the settings. Without this GPT models will run out of tokens before auto-compaction is run Release Notes: - (Preview only) Fixed an issue where auto compaction would not be triggered Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
Contributor
|
@zed-industries/approved |
1 similar comment
Contributor
|
@zed-industries/approved |
zed-zippy
Bot
removed
the
PR state:needs review
This comment was marked as duplicate.
This comment was marked as duplicate.
This was referenced Jun 18, 2026
Closed
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ustries#59469) (cherry-pick to preview) (zed-industries#59475) Cherry-pick of zed-industries#59469 to preview ---- Follow up to zed-industries#58883 This makes sure that we subtract the max output tokens before checking the threshold for auto compaction was reached, we had that logic before zed-industries#58883 but we lost it when introducing the settings. Without this GPT models will run out of tokens before auto-compaction is run Release Notes: - (Preview only) Fixed an issue where auto compaction would not be triggered Co-authored-by: Bennet Bo Fenner <bennet@zed.dev>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ustries#59469) Follow up to zed-industries#58883 This makes sure that we subtract the max output tokens before checking the threshold for auto compaction was reached, we had that logic before zed-industries#58883 but we lost it when introducing the settings. Without this GPT models will run out of tokens before auto-compaction is run Release Notes: - (Preview only) Fixed an issue where auto compaction would not be triggered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #58883
This makes sure that we subtract the max output tokens before checking the threshold for auto compaction was reached, we had that logic before #58883 but we lost it when introducing the settings. Without this GPT models will run out of tokens before auto-compaction is run
Release Notes: