settings_ui: Fix reset to default not clearing focused input fields - #59395
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
MartinYe1234
marked this pull request as ready for review
June 16, 2026 01:57
Contributor
Author
|
Before: Screen.Recording.2026-06-15.at.6.58.14.PM.movNow Screen.Recording.2026-06-15.at.7.03.54.PM.mov |
Anthony-Eid
approved these changes
Jun 16, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ed-industries#59395) When a setting was reset to its default while its input field was focused, the field kept showing the old value. The reconciliation that syncs the editor with the current setting value now handles cleared (null/empty) defaults and reconciles focused fields when they have no unsaved edits, so the field clears as expected. Release Notes: - Fixed settings input fields not clearing when a setting was reset to its default while the field was focused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a setting was reset to its default while its input field was focused, the field kept showing the old value. The reconciliation that syncs the editor with the current setting value now handles cleared (null/empty) defaults and reconciles focused fields when they have no unsaved edits, so the field clears as expected.
Release Notes: