Skip to content

agent_ui: Show commands in sandbox permission prompts #59391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtfeldman merged 1 commit into from
Jun 15, 2026
Merged

agent_ui: Show commands in sandbox permission prompts #59391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions crates/agent_ui/src/conversation_view/thread_view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7792,7 +7792,11 @@ impl ThreadView {
cx: &Context<Self>,
) -> AnyElement {
let has_network = details.network_all_hosts || !details.network_hosts.is_empty();
if details.write_paths.is_empty() && !has_network {
let command = details
.command
.as_deref()
.filter(|command| !command.is_empty());
if details.write_paths.is_empty() && !has_network && command.is_none() {
return Empty.into_any_element();
}

Expand Down Expand Up @@ -7904,6 +7908,11 @@ impl ThreadView {
return v_flex()
.border_t_1()
.border_color(self.tool_card_border_color(cx))
.when_some(command, |this, command| {
this.child(Self::render_sandbox_authorization_command(
entry_ix, command, cx,
))
})
.children(network_section)
.into_any_element();
}
Expand All @@ -7913,11 +7922,15 @@ impl ThreadView {
.contains(tool_call_id);
let mut paths = details.write_paths.clone();
paths.sort();
let command = details.command.as_deref();

v_flex()
.border_t_1()
.border_color(self.tool_card_border_color(cx))
.when_some(command, |this, command| {
this.child(Self::render_sandbox_authorization_command(
entry_ix, command, cx,
))
})
.children(network_section)
.child(
h_flex()
Expand Down Expand Up @@ -7955,11 +7968,6 @@ impl ThreadView {
}
})),
)
.when_some(command.filter(|_| is_open), |this, command| {
this.child(Self::render_sandbox_authorization_command(
entry_ix, command, cx,
))
})
.when(is_open && !paths.is_empty(), |this| {
this.child(
v_flex()
Expand Down
Loading