agent: Don't pass back the diff on successful edits - #59335
Merged
Conversation
Previous versions of the tool required passing the diff back because the parent agent wouldn't have known the edits applied otherwise. Given that we adapted this to use streaming tool calls now, this is redundant information and wastes context windows, especially for local models. We still pass the diff in the case that only some of the edits were applied, but in the successful case, we just let the model know that the edit was successful.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
anantdgoel
approved these changes
Jun 15, 2026
This was referenced Jun 18, 2026
Closed
liusuren123
pushed a commit
to liusuren123/zed
that referenced
this pull request
Jun 30, 2026
…9335) Previous versions of the tool required passing the diff back because the parent agent wouldn't have known the edits applied otherwise. Given that we adapted this to use streaming tool calls now, this is redundant information and wastes context windows, especially for local models. We still pass the diff in the case that only some of the edits were applied, but in the successful case, we just let the model know that the edit was successful. --- Release Notes: - agent: Improve edit tool performance with more succinct success response.
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…9335) Previous versions of the tool required passing the diff back because the parent agent wouldn't have known the edits applied otherwise. Given that we adapted this to use streaming tool calls now, this is redundant information and wastes context windows, especially for local models. We still pass the diff in the case that only some of the edits were applied, but in the successful case, we just let the model know that the edit was successful. --- Release Notes: - agent: Improve edit tool performance with more succinct success response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous versions of the tool required passing the diff back because the
parent agent wouldn't have known the edits applied otherwise. Given that
we adapted this to use streaming tool calls now, this is redundant
information and wastes context windows, especially for local models.
We still pass the diff in the case that only some of the edits were
applied, but in the successful case, we just let the model know that the
edit was successful.
Release Notes: