Skip to content

extension_ui: Hide agent servers from chips (#59231) (cherry-pick to preview) #59305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zed-zippy merged 1 commit into from
Jun 14, 2026
Merged

extension_ui: Hide agent servers from chips (#59231) (cherry-pick to preview) #59305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/cloud_api_types/src/extension.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,12 @@ pub struct ExtensionApiManifest {
#[serde(rename_all = "kebab-case")]
#[strum(serialize_all = "kebab-case")]
pub enum ExtensionProvides {
Languages,
Themes,
IconThemes,
Languages,
Grammars,
LanguageServers,
DebugAdapters,
ContextServers,
/// Deprecated
AgentServers,
Expand All @@ -49,7 +50,6 @@ pub enum ExtensionProvides {
/// Deprecated
IndexedDocsProviders,
Snippets,
DebugAdapters,
}

#[derive(Clone, Serialize, Deserialize, Debug, PartialEq)]
Expand Down
51 changes: 27 additions & 24 deletions crates/extensions_ui/src/extensions_ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1738,31 +1738,34 @@ impl Render for ExtensionsPage {
this.change_provides_filter(None, cx);
})),
)
.children(ExtensionProvides::iter().filter_map(|provides| {
match provides {
ExtensionProvides::SlashCommands
| ExtensionProvides::IndexedDocsProviders => return None,
_ => {}
}

let label = extension_provides_label(provides);
let button_id = SharedString::from(format!("filter-category-{}", label));

Some(
Button::new(button_id, label)
.style(if self.provides_filter == Some(provides) {
ButtonStyle::Filled
} else {
ButtonStyle::Subtle
})
.toggle_state(self.provides_filter == Some(provides))
.on_click({
cx.listener(move |this, _event, _, cx| {
this.change_provides_filter(Some(provides), cx);
.children(
ExtensionProvides::iter()
.filter(|provides| match provides {
ExtensionProvides::AgentServers
| ExtensionProvides::Grammars // grammars do not add anything of value to users currently
| ExtensionProvides::IndexedDocsProviders
| ExtensionProvides::SlashCommands => false,
_ => true,
})
.map(|provides| {
let label = extension_provides_label(provides);
let button_id =
SharedString::from(format!("filter-category-{}", label));

Button::new(button_id, label)
.style(if self.provides_filter == Some(provides) {
ButtonStyle::Filled
} else {
ButtonStyle::Subtle
})
}),
)
})),
.toggle_state(self.provides_filter == Some(provides))
.on_click({
cx.listener(move |this, _event, _, cx| {
this.change_provides_filter(Some(provides), cx);
})
})
}),
),
)
.child(self.render_feature_upsells(cx))
.child(v_flex().px_4().size_full().overflow_y_hidden().map(|this| {
Expand Down
Loading