Revert "gpui: Fix title bar clicks being delayed on macOS 27 (#58947)" - #59214
Merged
Conversation
This reverts commit c8554b4.
cla-bot
Bot
added
the
cla-signed
Member
Author
|
/cherry-pick preview |
zed-community-bot
Bot
added
the
staff
Anthony-Eid
approved these changes
Jun 12, 2026
cole-miller
added a commit
that referenced
this pull request
Jun 12, 2026
#59214) (cherry-pick to preview) (#59216) Cherry-pick of #59214 to preview ---- This reverts commit c8554b4. Reverting this because it broke dragging the settings UI window. Closes #59163 Release Notes: - Fixed not being able to drag the settings UI window on macOS. Co-authored-by: Cole Miller <cole@zed.dev>
This was referenced Jun 18, 2026
Closed
ypatodkar
pushed a commit
to ypatodkar/zed
that referenced
this pull request
Jun 25, 2026
## Summary macOS 27 Beta delays clicks in titlebar regions while AppKit determines whether a gesture should become a drag, single click, or double click. Zed's main workspace windows render a custom titlebar that already handles window movement via `Window::start_window_move`, so they do not need AppKit's native movable-titlebar behavior. This sets `is_movable` to `false` for the main `MultiWorkspace` windows and documents the `WindowOptions::is_movable` caveat for GPUI users with custom titlebars. ## Background The previous fix for this, zed-industries#58947, used AppKit's private `_opaqueRectForWindowMoveWhenInTitlebar` SPI to mark GPUI's full-size content view as app-owned titlebar content. That fixed delayed titlebar clicks, but was later reverted in zed-industries#59214 because it also affected windows that rely on AppKit's native titlebar dragging, like the settings window. This PR takes a narrower approach by only changing Zed's main custom-titlebar windows. Those windows already implement dragging explicitly via `Window::start_window_move`, so disabling AppKit's native movable-titlebar behavior fixes the macOS 27 Beta click delay without affecting other window types. Release Notes: - Fixed delayed clicks in the custom titlebar on macOS 27 Beta.
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ustries#58947)" (zed-industries#59214) (cherry-pick to preview) (zed-industries#59216) Cherry-pick of zed-industries#59214 to preview ---- This reverts commit c5feb35. Reverting this because it broke dragging the settings UI window. Closes zed-industries#59163 Release Notes: - Fixed not being able to drag the settings UI window on macOS. Co-authored-by: Cole Miller <cole@zed.dev>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…ustries#58947)" (zed-industries#59214) This reverts commit c5feb35. Reverting this because it broke dragging the settings UI window. Closes zed-industries#59163 Release Notes: - Fixed not being able to drag the settings UI window on macOS.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
## Summary macOS 27 Beta delays clicks in titlebar regions while AppKit determines whether a gesture should become a drag, single click, or double click. Zed's main workspace windows render a custom titlebar that already handles window movement via `Window::start_window_move`, so they do not need AppKit's native movable-titlebar behavior. This sets `is_movable` to `false` for the main `MultiWorkspace` windows and documents the `WindowOptions::is_movable` caveat for GPUI users with custom titlebars. ## Background The previous fix for this, zed-industries#58947, used AppKit's private `_opaqueRectForWindowMoveWhenInTitlebar` SPI to mark GPUI's full-size content view as app-owned titlebar content. That fixed delayed titlebar clicks, but was later reverted in zed-industries#59214 because it also affected windows that rely on AppKit's native titlebar dragging, like the settings window. This PR takes a narrower approach by only changing Zed's main custom-titlebar windows. Those windows already implement dragging explicitly via `Window::start_window_move`, so disabling AppKit's native movable-titlebar behavior fixes the macOS 27 Beta click delay without affecting other window types. Release Notes: - Fixed delayed clicks in the custom titlebar on macOS 27 Beta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c8554b4.
Reverting this because it broke dragging the settings UI window.
Closes #59163
Release Notes: