Skip to content

multi_buffer: Don't eagerly clone BufferSnapshot in range_to_buffer_ranges - #59190

Merged
Veykril merged 2 commits into
mainfrom
lukaswirth/push-xprolpnullxm
Jun 12, 2026
Merged

multi_buffer: Don't eagerly clone BufferSnapshot in range_to_buffer_ranges#59190
Veykril merged 2 commits into
mainfrom
lukaswirth/push-xprolpnullxm

Conversation

@Veykril

@Veykril Veykril commented Jun 12, 2026

Copy link
Copy Markdown
Member

Both cloning and dropping of these has quite a bit of overhead (despite them being snapshots), so avoid where possible, especially in display map syncing

Release Notes:

  • N/A or Added/Fixed/Improved ...

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 12, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 12, 2026
@Veykril
Veykril force-pushed the lukaswirth/push-xprolpnullxm branch from b145815 to e80b0a4 Compare June 12, 2026 10:26
@Veykril
Veykril requested a review from Anthony-Eid June 12, 2026 10:26
@Veykril
Veykril added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit b6c7496 Jun 12, 2026
33 checks passed
@Veykril
Veykril deleted the lukaswirth/push-xprolpnullxm branch June 12, 2026 12:30
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…r_ranges` (zed-industries#59190)

Both cloning and dropping of these has quite a bit of overhead (despite
them being snapshots), so avoid where possible, especially in display
map syncing

Release Notes:

- N/A or Added/Fixed/Improved ...
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…r_ranges` (zed-industries#59190)

Both cloning and dropping of these has quite a bit of overhead (despite
them being snapshots), so avoid where possible, especially in display
map syncing

Release Notes:

- N/A or Added/Fixed/Improved ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants