Repository navigation
Update Pull Request template #59062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChristopherBiscardi
merged 2 commits into
zed-industries:main
from
ChristopherBiscardi:pull-request-template-updates
Jun 12, 2026
Merged
Update Pull Request template #59062
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,45 @@ | ||
| Self-Review Checklist: | ||
| # Objective | ||
|
|
||
| - Describe the objective or issue this PR addresses. | ||
| - If you're fixing a specific issue, say "Fixes #X". | ||
|
|
||
| ## Solution | ||
|
|
||
| - Describe the solution used to achieve the objective above. | ||
|
ChristopherBiscardi marked this conversation as resolved.
|
||
|
|
||
| ## Testing | ||
|
|
||
| - Did you test these changes? If so, how? | ||
| - Are there any parts that need more testing? | ||
| - How can other people (reviewers) test your changes? Is there anything specific they need to know? | ||
| - If relevant, what platforms did you test these changes on, and are there any important ones you can't test? | ||
|
|
||
| ## Self-Review Checklist: | ||
|
|
||
| - [ ] I've reviewed my own diff for quality, security, and reliability | ||
| - [ ] Unsafe blocks (if any) have justifying comments | ||
| - [ ] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) | ||
| - [ ] Tests cover the new/changed behavior | ||
| - [ ] Performance impact has been considered and is acceptable | ||
|
|
||
| Closes #ISSUE | ||
| ## Showcase | ||
|
|
||
| > This section is optional. If this PR does not include a visual change or does not add a new user-facing feature, you can delete this section. | ||
|
|
||
| - Help others understand the result of this PR by showcasing your awesome work! | ||
| - If this PR includes a visual change, consider adding a screenshot, GIF, or video | ||
| - A before/after comparison is very useful for changes to existing features! | ||
|
|
||
| While a showcase should aim to be brief and digestible, you can use a toggleable section to save space on longer showcases: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure it's worth a mention here, but I sometimes like having a markdown table with a before/after for visual changes as it's easier to have them side by side to compare frequently |
||
|
|
||
| <details> | ||
| <summary>Click to view showcase</summary> | ||
|
|
||
| My super cool demos here | ||
|
|
||
| </details> | ||
|
|
||
| --- | ||
|
|
||
| Release Notes: | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.