Skip to content

Bump notify to fix a hang when watching or unwatching paths - #59047

Merged
cole-miller merged 1 commit into
mainfrom
bump-notify-hang-fix-main
Jun 10, 2026
Merged

Bump notify to fix a hang when watching or unwatching paths#59047
cole-miller merged 1 commit into
mainfrom
bump-notify-hang-fix-main

Conversation

@cole-miller

@cole-miller cole-miller commented Jun 10, 2026

Copy link
Copy Markdown
Member

For zed-industries/notify#5

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #ISSUE

Release Notes:

  • N/A

@cole-miller
cole-miller requested a review from as-cii June 10, 2026 16:54
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 10, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 10, 2026
@cole-miller cole-miller changed the title Bump notify Bump notify to fix a hang when watching or unwatching paths Jun 10, 2026

@as-cii as-cii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see my comment in #59045.

@cole-miller
cole-miller added this pull request to the merge queue Jun 10, 2026
Merged via the queue into main with commit c1b45aa Jun 10, 2026
46 checks passed
@cole-miller
cole-miller deleted the bump-notify-hang-fix-main branch June 10, 2026 17:16
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…stries#59047)

For zed-industries/notify#5

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes #ISSUE

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…stries#59047)

For zed-industries/notify#5

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes #ISSUE

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants