Skip to content

editor: Fix blocks not appearing or lingering when anchored past a soft wrap - #59018

Merged
smitbarmase merged 1 commit into
mainfrom
fix-block-removal-soft-wrapped-lines
Jun 15, 2026
Merged

editor: Fix blocks not appearing or lingering when anchored past a soft wrap#59018
smitbarmase merged 1 commit into
mainfrom
fix-block-removal-soft-wrapped-lines

Conversation

@smitbarmase

@smitbarmase smitbarmase commented Jun 10, 2026

Copy link
Copy Markdown
Member

I came across this while tackling another block map sync issue.

When a block is anchored past the point where its line soft wraps, inserting or removing it invalidated the wrong range of rows. Inserting such a block alone could silently not show it, and removing it could leave the block on screen.

To reproduce:

SEED=113 ITERATIONS=1 cargo test -p editor test_random_blocks

Release Notes:

  • Fixed inline assistant prompt sometimes not appearing, or lingering after dismissal, when that line was soft-wrapped.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 10, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 10, 2026
@smitbarmase
smitbarmase requested a review from Anthony-Eid June 10, 2026 17:21
@smitbarmase
smitbarmase added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit 6d0e7ff Jun 15, 2026
47 checks passed
@smitbarmase
smitbarmase deleted the fix-block-removal-soft-wrapped-lines branch June 15, 2026 07:59
This was referenced Jun 18, 2026
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…ft wrap (zed-industries#59018)

I came across this while tackling another block map sync issue.

When a block is anchored past the point where its line soft wraps,
inserting or removing it invalidated the wrong range of rows. Inserting
such a block alone could silently not show it, and removing it could
leave the block on screen.

To reproduce: 

```sh
SEED=113 ITERATIONS=1 cargo test -p editor test_random_blocks
```

Release Notes:

- Fixed inline assistant prompt sometimes not appearing, or lingering
after dismissal, when that line was soft-wrapped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants