agent: Fix handoff feature flag tests - #58916
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
bennetbo
enabled auto-merge
June 9, 2026 12:06
zed-community-bot
Bot
added
the
staff
zed-zippy
Bot
added
the
PR state:needs review
Contributor
|
@zed-industries/approved |
zed-zippy
Bot
removed
the
PR state:needs review
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Accidentally broke CI in zed-industries#58891 Since https://github.com/zed-industries/zed/blob/c68bc98bacb80c34df0e1b6ef4de186d763b3820/crates/feature_flags/src/store.rs#L180 defaults to true in debug mode (effectively sets staff to `true`) the tests would fail. We can work around this by manually disabling the feature flag for tests in settings. Also, since we are planning to ship to preview tomorrow these tests will be removed soon. Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Accidentally broke CI in zed-industries#58891 Since https://github.com/zed-industries/zed/blob/c68bc98bacb80c34df0e1b6ef4de186d763b3820/crates/feature_flags/src/store.rs#L180 defaults to true in debug mode (effectively sets staff to `true`) the tests would fail. We can work around this by manually disabling the feature flag for tests in settings. Also, since we are planning to ship to preview tomorrow these tests will be removed soon. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally broke CI in #58891
Since
zed/crates/feature_flags/src/store.rs
Line 180 in c68bc98
defaults to true in debug mode (effectively sets staff to
true) the tests would fail.We can work around this by manually disabling the feature flag for tests in settings.
Also, since we are planning to ship to preview tomorrow these tests will be removed soon.
Release Notes: