Skip to content

Fix Deno test task example quoting - #58774

Merged
ChristopherBiscardi merged 1 commit into
zed-industries:mainfrom
MohitGoyal09:fix-deno-task-example-quoting
Jun 9, 2026
Merged

Fix Deno test task example quoting#58774
ChristopherBiscardi merged 1 commit into
zed-industries:mainfrom
MohitGoyal09:fix-deno-task-example-quoting

Conversation

@MohitGoyal09

Copy link
Copy Markdown
Contributor

Updates the Deno runnable support docs so the copied test task uses $ZED_FILE without nested single quotes. With the old example, Zed's task shell wrapper could produce a command with conflicting quotes and fail when running deno test.

Testing:

  • pnpm dlx prettier@3.5.0 docs/src/languages/deno.md --check
  • git diff --check

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #58072

Release Notes:

  • N/A

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 7, 2026
@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Jun 7, 2026
@ChristopherBiscardi ChristopherBiscardi added the area:docs This is a PR label! For issues use issue type 'Docs' instead. label Jun 9, 2026

@ChristopherBiscardi ChristopherBiscardi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ChristopherBiscardi
ChristopherBiscardi added this pull request to the merge queue Jun 9, 2026
Merged via the queue into zed-industries:main with commit 6d42d62 Jun 9, 2026
52 checks passed
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
Updates the Deno runnable support docs so the copied test task uses
`$ZED_FILE` without nested single quotes. With the old example, Zed's
task shell wrapper could produce a command with conflicting quotes and
fail when running `deno test`.

Testing:

- `pnpm dlx prettier@3.5.0 docs/src/languages/deno.md --check`
- `git diff --check`

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#58072

Release Notes:

- N/A
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
Updates the Deno runnable support docs so the copied test task uses
`$ZED_FILE` without nested single quotes. With the old example, Zed's
task shell wrapper could produce a command with conflicting quotes and
fail when running `deno test`.

Testing:

- `pnpm dlx prettier@3.5.0 docs/src/languages/deno.md --check`
- `git diff --check`

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes zed-industries#58072

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs This is a PR label! For issues use issue type 'Docs' instead. cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deno test tasks section uses misplaced quotes

2 participants