Skip to content

Use SHORT_SHA_LENGTH for all shortened commit SHAs - #58741

Merged
Veykril merged 2 commits into
zed-industries:mainfrom
albertbogusz:short-commit-sha-consistency
Jun 8, 2026
Merged

Use SHORT_SHA_LENGTH for all shortened commit SHAs#58741
Veykril merged 2 commits into
zed-industries:mainfrom
albertbogusz:short-commit-sha-consistency

Conversation

@albertbogusz

@albertbogusz albertbogusz commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Fixes hardcoded SHA lengths not using the SHORT_SHA_LENGTH constant.

Release Notes:

  • Reduced short commit SHAs in blame and commit tooltips from 8 to 7 - consistent with the graph and history views.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 6, 2026
@cole-miller

Copy link
Copy Markdown
Member

Thanks!

@cole-miller
cole-miller enabled auto-merge June 8, 2026 01:10
auto-merge was automatically disabled June 8, 2026 01:13

Head branch was pushed to by a user without write access

@albertbogusz

Copy link
Copy Markdown
Collaborator Author

Fixed a failing formatting test

@albertbogusz
albertbogusz requested a review from cole-miller June 8, 2026 01:21
@Veykril
Veykril enabled auto-merge June 8, 2026 06:31
@Veykril
Veykril added this pull request to the merge queue Jun 8, 2026
Merged via the queue into zed-industries:main with commit f99fe5d Jun 8, 2026
33 checks passed
@albertbogusz
albertbogusz deleted the short-commit-sha-consistency branch June 8, 2026 11:28
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 8, 2026
…58741)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Fixes hardcoded SHA lengths not using the `SHORT_SHA_LENGTH` constant.

Release Notes:

- Reduced short commit SHAs in blame and commit tooltips from 8 to 7 -
consistent with the graph and history views.
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…58741)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Fixes hardcoded SHA lengths not using the `SHORT_SHA_LENGTH` constant.

Release Notes:

- Reduced short commit SHAs in blame and commit tooltips from 8 to 7 -
consistent with the graph and history views.
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…58741)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Fixes hardcoded SHA lengths not using the `SHORT_SHA_LENGTH` constant.

Release Notes:

- Reduced short commit SHAs in blame and commit tooltips from 8 to 7 -
consistent with the graph and history views.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants