Use SHORT_SHA_LENGTH for all shortened commit SHAs - #58741
Merged
Veykril merged 2 commits intoJun 8, 2026
Conversation
Member
|
Thanks! |
cole-miller
enabled auto-merge
June 8, 2026 01:10
cole-miller
approved these changes
Jun 8, 2026
auto-merge was automatically disabled
June 8, 2026 01:13
Head branch was pushed to by a user without write access
Collaborator
Author
|
Fixed a failing formatting test |
Veykril
enabled auto-merge
June 8, 2026 06:31
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…58741) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Fixes hardcoded SHA lengths not using the `SHORT_SHA_LENGTH` constant. Release Notes: - Reduced short commit SHAs in blame and commit tooltips from 8 to 7 - consistent with the graph and history views.
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…58741) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Fixes hardcoded SHA lengths not using the `SHORT_SHA_LENGTH` constant. Release Notes: - Reduced short commit SHAs in blame and commit tooltips from 8 to 7 - consistent with the graph and history views.
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…58741) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Fixes hardcoded SHA lengths not using the `SHORT_SHA_LENGTH` constant. Release Notes: - Reduced short commit SHAs in blame and commit tooltips from 8 to 7 - consistent with the graph and history views.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Fixes hardcoded SHA lengths not using the
SHORT_SHA_LENGTHconstant.Release Notes: