Skip to content

Remove experimental microphone gain normalization option - #58677

Merged
ConradIrwin merged 1 commit into
mainfrom
remove-experimental-mic-gain-normalization
Jun 5, 2026
Merged

Remove experimental microphone gain normalization option#58677
ConradIrwin merged 1 commit into
mainfrom
remove-experimental-mic-gain-normalization

Conversation

@ConradIrwin

Copy link
Copy Markdown
Member

Release Notes:

The webRTC APM's adaptive digital gain control now levels microphone
capture, replacing the rodio-based automatic gain control that was gated
behind the experimental.auto_microphone_volume setting. Remove that
setting and its supporting code.

The webRTC gain normalization was introduced in #58036.
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 5, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 5, 2026
@ConradIrwin
ConradIrwin enabled auto-merge June 5, 2026 16:40
@ConradIrwin
ConradIrwin added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit b762980 Jun 5, 2026
43 checks passed
@ConradIrwin
ConradIrwin deleted the remove-experimental-mic-gain-normalization branch June 5, 2026 16:52
@zed-zippy zed-zippy Bot added the PR state:needs review Used to label PRs that are in need of a post-merge approval label Jun 5, 2026
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 8, 2026
…ies#58677)

Release Notes:

- Removed the `experimental.auto_microphone_volume` setting (since
zed-industries#58036 microphone volumes are now normalized by default)
@cole-miller

Copy link
Copy Markdown
Member

@zed-industries/approved

@zed-zippy zed-zippy Bot removed the PR state:needs review Used to label PRs that are in need of a post-merge approval label Jun 9, 2026
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
…ies#58677)

Release Notes:

- Removed the `experimental.auto_microphone_volume` setting (since
zed-industries#58036 microphone volumes are now normalized by default)
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
…ies#58677)

Release Notes:

- Removed the `experimental.auto_microphone_volume` setting (since
zed-industries#58036 microphone volumes are now normalized by default)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants