Skip to content

Use no-op hasher for TypeId hashing - #58629

Merged
Veykril merged 2 commits into
mainfrom
push-yznxkqklywkn
Jun 5, 2026
Merged

Use no-op hasher for TypeId hashing#58629
Veykril merged 2 commits into
mainfrom
push-yznxkqklywkn

Conversation

@Veykril

@Veykril Veykril commented Jun 5, 2026

Copy link
Copy Markdown
Member

TypeId is effectively already a hash, so re-hashing it with fxhash is unnecessary.

Release Notes:

  • N/A or Added/Fixed/Improved ...

@Veykril
Veykril requested a review from Anthony-Eid June 5, 2026 09:19
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 5, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 5, 2026

@osiewicz osiewicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Veykril
Veykril added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit a85f8ad Jun 5, 2026
32 checks passed
@Veykril
Veykril deleted the push-yznxkqklywkn branch June 5, 2026 10:35
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 8, 2026
TypeId is effectively already a hash, so re-hashing it with fxhash is
unnecessary.

Release Notes:

- N/A or Added/Fixed/Improved ...

---------

Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
This was referenced Jun 18, 2026
jonx pushed a commit to jonx/zed-aros that referenced this pull request Jul 17, 2026
TypeId is effectively already a hash, so re-hashing it with fxhash is
unnecessary.

Release Notes:

- N/A or Added/Fixed/Improved ...

---------

Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
jolutz pushed a commit to jolutz/zed that referenced this pull request Aug 8, 2026
TypeId is effectively already a hash, so re-hashing it with fxhash is
unnecessary.

Release Notes:

- N/A or Added/Fixed/Improved ...

---------

Co-authored-by: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants