Remove double-click handling from git panel filenames - #58594
Merged
ChristopherBiscardi merged 1 commit intoJun 4, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
JosephTLyons
approved these changes
Jun 4, 2026
maxdeviant
changed the title
ChristopherBiscardi
enabled auto-merge
June 4, 2026 22:55
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…#58594) Previously in the git panel, double clicking a filename would trigger both the first-click action *and* the second-click action. This PR removes the second click handling since we don't have a good pattern for single-and-double-click handling. ### Before https://github.com/user-attachments/assets/f03e53ae-a330-4f60-812d-a45a2d3f5f30 ### After https://github.com/user-attachments/assets/e09493a1-6477-4d43-80ea-26322dd1f083 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…#58594) Previously in the git panel, double clicking a filename would trigger both the first-click action *and* the second-click action. This PR removes the second click handling since we don't have a good pattern for single-and-double-click handling. ### Before https://github.com/user-attachments/assets/f03e53ae-a330-4f60-812d-a45a2d3f5f30 ### After https://github.com/user-attachments/assets/e09493a1-6477-4d43-80ea-26322dd1f083 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…#58594) Previously in the git panel, double clicking a filename would trigger both the first-click action *and* the second-click action. This PR removes the second click handling since we don't have a good pattern for single-and-double-click handling. ### Before https://github.com/user-attachments/assets/f03e53ae-a330-4f60-812d-a45a2d3f5f30 ### After https://github.com/user-attachments/assets/e09493a1-6477-4d43-80ea-26322dd1f083 Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in the git panel, double clicking a filename would trigger both the first-click action and the second-click action.
This PR removes the second click handling since we don't have a good pattern for single-and-double-click handling.
Before
Screen.Recording.2026-06-04.at.3.47.29.PM.mov
After
Screen.Recording.2026-06-04.at.3.48.20.PM.mov
Self-Review Checklist:
Release Notes: